Re: [PATCH 2/2] ALSA: compress: Pass id string to snd_compress_new

From: kbuild test robot
Date: Wed Nov 25 2015 - 05:15:54 EST


Hi Richard,

[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.4-rc2 next-20151124]

url: https://github.com/0day-ci/linux/commits/Richard-Fitzgerald/ALSA-compress-Add-procfs-info-file-for-compressed-nodes/20151125-175147
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: i386-randconfig-n0-201547 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

sound/core/compress_offload.c: In function 'snd_compress_proc_done':
sound/core/compress_offload.c:958:1: error: expected ';' before '}' token
}
^
sound/core/compress_offload.c: In function 'snd_compress_new':
>> sound/core/compress_offload.c:994:17: error: 'struct snd_compr' has no member named 'id'
strlcpy(compr->id, id, sizeof(compr->id));
^
sound/core/compress_offload.c:994:39: error: 'struct snd_compr' has no member named 'id'
strlcpy(compr->id, id, sizeof(compr->id));
^

vim +994 sound/core/compress_offload.c

952 return 0;
953 }
954
955 static int snd_compress_proc_done(struct snd_compr *compr)
956 {
957 return 0
> 958 }
959 #endif
960
961 static int snd_compress_dev_free(struct snd_device *device)
962 {
963 struct snd_compr *compr;
964
965 compr = device->device_data;
966 snd_compress_proc_done(compr);
967 put_device(&compr->dev);
968 return 0;
969 }
970
971 /*
972 * snd_compress_new: create new compress device
973 * @card: sound card pointer
974 * @device: device number
975 * @dirn: device direction, should be of type enum snd_compr_direction
976 * @compr: compress device pointer
977 */
978 int snd_compress_new(struct snd_card *card, int device,
979 int dirn, const char *id, struct snd_compr *compr)
980 {
981 static struct snd_device_ops ops = {
982 .dev_free = snd_compress_dev_free,
983 .dev_register = snd_compress_dev_register,
984 .dev_disconnect = snd_compress_dev_disconnect,
985 };
986 int ret;
987
988 compr->card = card;
989 compr->device = device;
990 compr->direction = dirn;
991
992 if (IS_ENABLED(CONFIG_SND_VERBOSE_PROCFS))
993 if (id)
> 994 strlcpy(compr->id, id, sizeof(compr->id));
995
996 snd_device_initialize(&compr->dev, card);
997 dev_set_name(&compr->dev, "comprC%iD%i", card->number, device);

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data