Re: [PATCH v3 6/7] spi: imx: return error from dma channel request

From: Anton Bondarenko
Date: Sat Nov 14 2015 - 05:05:42 EST




On 05.11.2015 17:00, Anton Bondarenko wrote:
On 05.11.2015 09:56, Sascha Hauer wrote:
On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote:
From: Anton Bondarenko <anton_bondarenko@xxxxxxxxxx>

On SDMA initialization return exactly the same error, which is
reported by dma_request_slave_channel_reason(), it is a preceding
change to defer SPI DMA initialization, if SDMA module is not yet
available.

Maybe something like: "fix probe deferral when dmaengine is not yet
available" in the subject line will better express that this is a patch
that should be applied ASAP. Also you can move this up to the front of
the series when resending.

Sascha


This patch itself does not implement deferral for spi-imx if dmaengine
not ready. The patch targets 2 things: give a bit more detailed error
information of SPI dma slave channel initialization error and provide a
basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi
initialization, if DMA engine is pending).

Regards, Anton

Does anyone has other comments regarding this commit?

Regards, Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/