Re: [PATCH 1/4] ktime: add a roundup function

From: Jacob Pan
Date: Fri Nov 13 2015 - 17:34:16 EST


On Fri, 13 Nov 2015 12:11:01 -0800
John Stultz <john.stultz@xxxxxxxxxx> wrote:

> Could you add a comment as to what the function does, and use some
> better variable names here to make it more immediately obvious what is
> being done here?
>
> Something like:
> /**
> * ktime_roundup - Rounds value up to interval chunk
> * @ value: Value to be rounded up
> * @ interval: interval size to round up to
> *
> * Rounds a value up to the next higher multiple of an interval size
> */
> static inline ktime ktime_roundup(ktime_t value, ktime_t interval)
will do. thank you for taking the time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/