Re: [PATCH] x86/mm: fix regression with huge pages on PAE

From: Dan Williams
Date: Fri Nov 13 2015 - 04:01:33 EST


On Thu, Nov 12, 2015 at 11:29 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Nov 12, 2015 at 12:00 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
[..]
> I have this dim memory of us playing around with just making PAGE_SIZE
> (and thus PAGE_MASK) always be signed, but that it caused other
> problems. Signed types have downsides too.

FWIW, I ran into this recently with the pfn_t patch. mips and powerpc
have PAGE_MASK as a signed int.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/