Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

From: Clemens Ladisch
Date: Fri Nov 13 2015 - 03:11:48 EST


Felipe Ferreri Tonello wrote:
> On 10/11/15 18:43, Sergei Shtylyov wrote:
>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>> struct usb_ep *in_ep, *out_ep;
>>> struct snd_card *card;
>>> struct snd_rawmidi *rmidi;
>>> + u8 ms_id;
>>
>> Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned.

It's not in the original mail, which contains tab characters.

> Here is from my local git diff:
>
> @@ -75,6 +75,7 @@ struct f_midi {
> struct usb_ep *in_ep, *out_ep;
> struct snd_card *card;
> struct snd_rawmidi *rmidi;
> + u8 ms_id;

Apparently, you're using four spaces per tab. Linux uses eight.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/