Re: [PATCH] smpboot: Add smpboot state variables instead of reusing CPU hotplug states

From: Daniel Wagner
Date: Thu Nov 12 2015 - 09:34:14 EST


Hi Paul,

On 11/07/2015 08:17 AM, Paul E. McKenney wrote:
> On Thu, Oct 15, 2015 at 01:32:44PM +0200, Daniel Wagner wrote:
>> The cpu hotplug state machine in smpboot.c is reusing the states from
>> cpu.h. That is confusing when it comes to the CPU_DEAD_FROZEN usage.
>> Paul explained to me that he was in need of an additional state
>> for destinguishing between a CPU error states. For this he just
>> picked CPU_DEAD_FROZEN.
>>
>> 8038dad7e888581266c76df15d70ca457a3c5910 smpboot: Add common code for notification from dying CPU
>> 2a442c9c6453d3d043dfd89f2e03a1deff8a6f06 x86: Use common outgoing-CPU-notification code
>>
>> Instead of reusing the states, let's add new definition inside
>> the smpboot.c file with explenation what those states
>> mean. Thanks Paul for providing them.
>>
>> Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
>
> Apologies for the delay, I didn't realize that you were waiting on me.

No apology needed. I didn't express my wish explicitly. I'll post it
again after the merge window is closed.

> Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/