Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

From: Elias Vanderstuyft
Date: Tue Nov 10 2015 - 16:42:52 EST


On Mon, Nov 9, 2015 at 8:50 AM, Benjamin Tissoires <btissoir@xxxxxxxxxx> wrote:
>
> ----- Original Message -----
>> From: "Elias Vanderstuyft" <elias.vds@xxxxxxxxx>
>> To: "Benjamin Tissoires" <benjamin.tissoires@xxxxxxxxxx>
>> Cc: "Dmitry Torokhov" <dmitry.torokhov@xxxxxxxxx>, "David Herrmann" <dh.herrmann@xxxxxxxxx>, "Peter Hutterer"
>> <peter.hutterer@xxxxxxxxx>, "open list:HID CORE LAYER" <linux-input@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
>> Sent: Sunday, November 8, 2015 11:55:04 AM
>> Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl
>>
>> I.e., why not:
>>
>> struct uinput_setup {
>> char name[UINPUT_MAX_NAME_SIZE];
>> struct input_id id;
>> __u32 ff_effects_max;
>> };
>>
>> In case you would change this, also make sure to change the order in
>> the documentation of UI_DEV_SETUP.
>>
>
> Works for me.
> Dmitry, how do you want to handle this change? Me re-sending the whole series or you applying the change directly on your tree?

If this is too much of a hassle, please leave it as it was, I was just
being pedantic ;-)

Cheers,
Elias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/