Re: [PATCH V2 2/5] PM / OPP: Add {opp-microvolt|opp-microamp|turbo-mode|opp-suspend}-<name> binding

From: Rob Herring
Date: Tue Nov 10 2015 - 10:38:01 EST


On Tue, Nov 10, 2015 at 8:55 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 06-11-15, 07:23, Viresh Kumar wrote:
>> Yeah, but in that case 1200 *may* not be a turbo frequency anymore, as
>> the voltage constraints might have changed.
>>
>> So turbo frequency is something that should be used only in small
>> bursts, as they are consume lot of power. They aren't available to be
>> used freely. They may also have thermal side effects..
>>
>> In a similar way, for suspend-freq, we may or may not want the lowest
>> frequency to be used during suspend and so that can change as well.
>> And we shouldn't have suspend-freq set for two OPP nodes.
>
> @Rob: Does my comments make any sense now? Or you still think we are
> doing something wrong here?

What you said could be possible, but I'm still doubtful. I would drop
these until you have an actual user.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/