Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

From: John Garry
Date: Mon Nov 09 2015 - 11:55:39 EST


On 09/11/2015 16:28, Arnd Bergmann wrote:
On Tuesday 10 November 2015 00:32:16 John Garry wrote:
}

+static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
+{
+ int i;
+
+ for (i = 0; i < hisi_hba->n_phy; i++)
+ memcpy(&hisi_hba->phy[i].dev_sas_addr,
+ hisi_hba->sas_addr,
+ SAS_ADDR_SIZE);
+}

I don't know the background here, but I thought it would have to
be a different address on each phy. Are you sure this is not the
case?

Arnd

.


Hi,

Each controller should have a unique SAS addr but not each phy.

Regards,
john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/