Re: [PATCH] staging: lustre: Handle nodemask on UMP machines

From: Sudip Mukherjee
Date: Mon Nov 09 2015 - 06:19:50 EST


On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote:
> For UMP and SMP machines the struct cfs_cpt_table are
> defined differently. In the case handled by this patch
> nodemask is defined as a integer for the UMP case and
> as a pointer for the SMP case. This will cause a problem
> for ost_setup which reads the nodemask directly. Instead
> we create a UMP version of cfs_cpt_nodemask and use that
> in ost_setup.
>
> Signed-off-by: James Simmons <uja.ornl@xxxxxxxxx>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199
> Reviewed-on: http://review.whamcloud.com/9219
> Reviewed-by: Liang Zhen <liang.zhen@xxxxxxxxx>
> Reviewed-by: Li Xi <pkuelelixi@xxxxxxxxx>
> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>

Signed-off-by: and Reviewed-by: tags entered two times. Once here.
>
> Starting in 3.14 kernels nodemask_t was changed from a
> a unsigned long to a linux bitmap so more than 32 cores
> could be supported. Using set_bit in cfs_cpt_table_alloc
> no longer compiles so this patch backports bits of the
> node management function that use a linux bitmap back
> end. Cleaned up libcfs bitmap.h to use the libcfs layers
> memory allocation function. This was pulling in lustre
> related code that was not defined.
>
> Signed-off-by: James Simmons <uja.ornl@xxxxxxxxx>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4993
> Reviewed-on: http://review.whamcloud.com/10332
> Reviewed-by: Liang Zhen <liang.zhen@xxxxxxxxx>
> Reviewed-by: Bob Glossman <bob.glossman@xxxxxxxxx>
> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>

And then again here.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/