Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions

[Andy Shevchenko]

On Mon, Nov 9, 2015 at 5:07 AM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote:
>
>
> On 11/8/2015 3:09 PM, Andy Shevchenko wrote:
>>
>> On Sun, Nov 8, 2015 at 6:52 AM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote:
>>>
>>> This patch adds supporting utility functions
>>> for selftest. The intention is to share the self
>>> test code between different drivers.
>>>
>>> Supported test cases include:
>>> 1. dma_map_single
>>> 2. streaming DMA
>>> 3. coherent DMA
>>> 4. scatter-gather DMA
>>
>>

>>> +       u32 i, j = 0;
>>
>> unsigned int
>
> why?

Is i or j is going to be used for HW communication? No? What about
assignment to a values of type u32? No? Plain counters? Use plain
types.

It's actually comment about your all patches I saw last week.

>>> +       int err = 0;
>>> +       int ret;
>>
>>
>> Any reason to have two instead of one of similar meaning?
>>
>
> removed ret

Don't forget to check if it's redundant assignment (check in all your
patches as well).

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/