Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels

[Andy Lutomirski]

On Sat, Nov 7, 2015 at 9:08 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Sat, 7 Nov 2015, Andy Lutomirski wrote:
>> On Sat, Nov 7, 2015 at 8:58 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> True.  But I hid it in a header file, too, but it was just a different
>> header file -- I had it all hidden away as CALL_ENTER_FROM_USER_MODE.
>
> It probably does not really make a difference :)
>
> I just got triggered by you saying:
>
>> Unfortunately, these only work if HAVE_JUMP_LABEL ....

Yeah, I don't really like that either.  I think that the real fix
would be to compile in the runtime jump label bits unconditionally.
Admittedly it would bloat the kernel image a little bit for
!CONFIG_JUMP_LABEL or if build with an older gcc, and that's even less
appropriate for 4.4 at this point.  Peter?

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/