Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER"

From: Mark Brown
Date: Fri Nov 06 2015 - 05:22:53 EST


On Fri, Nov 06, 2015 at 03:02:57PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@xxxxxxxxxx>:
> > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote:
> >> ARCH_TEGRA selects RESET_CONTROLLER.
> >> The dependency "depends on RESET_CONTROLLER" is already met.

> >> tristate "NVIDIA Tegra114 SPI Controller"
> >> depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST
> >> - depends on RESET_CONTROLLER && HAS_DMA
> >> + depends on HAS_DMA

> > Again, this driver doesn't depend on ARCH_TEGRA.

> How come?

> Sorry, I have not been tracking this sub-system,
> so I do not get the "Again".

It's the same issue as your previous patch - there's an || COMPILE_TEST
in there.

Attachment: signature.asc
Description: PGP signature