Re: [PATCH 3/4] scsi: fix compiler warning for sg

From: Timur Tabi
Date: Thu Nov 05 2015 - 10:25:20 EST


Sinan Kaya wrote:
>
>
> #define MULDIV(X,MUL,DIV) mult_frac64(X, MUL, DIV)

Why bother with the macro at all? Just change the code to use do_div() directly. It's possible that the original code was written before do_div() became standard, or the developer didn't know about, which is why we have this macro in the first place.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/