Re: [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry)

From: Don Zickus
Date: Thu Nov 05 2015 - 09:46:10 EST


On Tue, Nov 03, 2015 at 04:20:57PM +0100, Ulrich Obergfell wrote:
> This patch set addresses various races in relation to CPU hotplug
> and a race in relation to watchdog timer expiry. I discovered the
> corner cases during code inspection. I haven't seen any of these
> issues occur in practice.

Series looks fine to me. I have run some local panic tests with no
problems, along with modifying various values and everything seems fine.

Acked-by: Don Zickus <dzickus@xxxxxxxxxx>

>
> Ulrich Obergfell (4):
> watchdog: avoid race between lockup detector suspend/resume and CPU
> hotplug
> watchdog: avoid races between /proc handlers and CPU hotplug
> watchdog: remove {get|put}_online_cpus() from
> watchdog_{park|unpark}_threads()
> watchdog: fix race between proc_watchdog_thresh() and
> watchdog_timer_fn()
>
> kernel/watchdog.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> --
> 1.7.11.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/