Re: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put"

From: Dan Carpenter
Date: Thu Nov 05 2015 - 08:53:07 EST


Relying on hidden sanity checks makes the code harder to read. A human
being cannot remember which functions have sanity checks and which do
not. These sorts of patches are easy to generate automatically but they
make the code worse. There are so many *better* things to do instead of
focusing on making the code bad.

Please stop sending these patches for drivers/staging. You are welcome
to send them for other subsystems which I don't care about.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/