Re: [PATCH] net: stmmac: remove unneeded phy_iface variable

From: David Miller
Date: Thu Nov 05 2015 - 00:30:23 EST


From: LABBE Corentin <clabbe.montjoie@xxxxxxxxx>
Date: Wed, 4 Nov 2015 21:08:12 +0100

> The variable phy_iface is double-initialized and finally is not necessary
> at all.
>
> Reported-by: coverity (CID 1271141)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@xxxxxxxxx>

The value is used in two locations, so having it computed once in a
variable is useful.

Please just eliminate the double assignment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/