Re: [PATCH] block: Don't allow illegal discard requests

From: Christoph Hellwig
Date: Wed Nov 04 2015 - 06:30:26 EST


On Wed, Nov 04, 2015 at 10:18:41AM +0100, Jan Kara wrote:
> Currently blkdev_issue_discard() doesn't check that submitted discard
> request matches granularity required by the underlying device.
> Submitting such requests to the device can have unexpected consequences
> (e.g. brd driver just discards more / less data depending on how exactly
> the request is aligned). So test that submitted discard request has the
> granularity required by the driver.

How is this going to work with stacked drivers? I think brd needs to
be fixed to take care of the granularity itself, just like we did for
request based drivers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/