Re: [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout

From: Jiri Olsa
Date: Wed Nov 04 2015 - 03:49:02 EST


On Mon, Nov 02, 2015 at 05:50:24PM -0800, Andi Kleen wrote:

SNIP

> @@ -729,32 +722,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
> if (prefix)
> fprintf(output, "%s", prefix);
>
> - if (scaled == -1 || !counter->supported) {
> - fprintf(output, "%*s%s",
> - csv_output ? 0 : 18,
> - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> - csv_sep);
> - fprintf(output, "%-*s%s",
> - csv_output ? 0 : unit_width,
> - counter->unit, csv_sep);
> - fprintf(output, "%*s",
> - csv_output ? 0 : -25,
> - perf_evsel__name(counter));

so this changed current 'not supported' output:

<not supported> stalled-cycles-frontend
<not supported> stalled-cycles-backend


into

0 stalled-cycles-frontend
0 stalled-cycles-backend # 0.00% backend cycles idle

> -
> - if (counter->cgrp)
> - fprintf(output, "%s%s", csv_sep, counter->cgrp->name);

haven't tried with cgroup, but I think that removing
above hunk will not do any good to it..

jirka

> -
> - print_running(avg_running, avg_enabled);
> - fputc('\n', output);
> - return;
> - }
> -
> uval = avg * counter->scale;
> - printout(-1, 0, counter, uval, prefix);
> -

SNIP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/