Re: MMC/regulator boot hang in -next

From: Mark Brown
Date: Tue Nov 03 2015 - 00:36:15 EST


On Mon, Nov 02, 2015 at 03:04:29PM -0800, John Stultz wrote:
> On Mon, Nov 2, 2015 at 2:58 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > No, the internal get voltage call shouldn't be locking in the first
> > place (and indeed it doesn't do so AFAICT?).

> } else if (rdev->supply) {
> ret = regulator_get_voltage(rdev->supply); <-----
> } else {

> Where _regulator_get_voltage() is called from
> regulator_set_voltage_unlocked(), called from regulator_set_voltage().
>

Well, that's the issue then - get_voltage() needs to be locking the
supplies like set_voltage() does.

Attachment: signature.asc
Description: PGP signature