Re: [Y2038] [PATCH V2] hp_sdc_rtc: fixed y2038 problem in proc_show

[Dmitry Torokhov]

On Wed, Sep 16, 2015 at 03:55:37PM +0200, Arnd Bergmann wrote:
> On Wednesday 16 September 2015 21:45:38 WEN Pingbo wrote:
> > hp_sdc_rtc_proc_show() use timeval to store the time, which will
> > overflowed in 2038.
> > 
> > This patch fixes this problem by replacing timeval with timespec64.
> > hp_sdc_rtc_proc_show() only output string, so that userspace will work
> > normally if we apply this patch.
> > 
> > Not all timer in i8042 have y2038 risk(handshake, match timer, etc),
> > Replacements in those timer are just for consistency.
> > 
> > Version 2 Updates:
> > - compiled in m68k gcc cross compiler(4.6.3), no extra warnings
> > - placed s64 type cast in tv.tv_sec, making sure it work properly in
> > both 32bit and 64bit platform.
> > 
> > Signed-off-by: WEN Pingbo <pingbo.wen@xxxxxxxxxx>
> > Cc: Y2038 <y2038@xxxxxxxxxxxxxxxx>
> > 
> 
> Looks very good,
> 
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/