[PATCH 2/2] isdn: correctly check failed allocation

From: Insu Yun
Date: Thu Oct 15 2015 - 12:29:31 EST


Since skb_clone is memory allocation, it could be failed when lack of resource.
Therefore, return value of skb_clone needs to be checked and handle error.

Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx>
---
drivers/isdn/mISDN/layer2.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index 949cabb..888c610 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -1509,6 +1509,12 @@ l2_pull_iqueue(struct FsmInst *fi, int event, void *arg)
}

nskb = skb_clone(skb, GFP_ATOMIC);
+ if (!nskb) {
+ printk(KERN_WARNING "%s: no skb mem in %s\n",
+ mISDNDevName4ch(&l2->ch), __func__);
+ return;
+ }
+
p1 = skb_headroom(nskb);
if (p1 >= i)
memcpy(skb_push(nskb, i), header, i);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/