Re: [PATCH] ahci: qoriq: Fix a compiling warning

From: Arnd Bergmann
Date: Thu Oct 15 2015 - 11:36:08 EST


On Thursday 15 October 2015 11:11:52 Tejun Heo wrote:
>
> On Wed, Oct 14, 2015 at 04:46:52PM +0800, Tang Yuantian wrote:
> > kbuild test robot reports the warnings:
> > drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
> > >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used
> > >> uninitialized in this function [-Wuninitialized]
> > drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here
> > >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used
> > >> uninitialized in this function [-Wuninitialized]
> > drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here
> >
> > This patch fixed it by introducing a local variable.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Hmmm... why is the patch signed off by Arnd? You can't sign off for
> other people. If this was suggested by Arnd, please use
> "Suggested-by:" or "Original-patch-by:".

The original patch I sent had my Signed-off-by, see
https://lkml.org/lkml/2015/9/14/64

Tang Yuantian now submitted it properly with a full changelog text
but forgot to add the 'From: Arnd Bergmann <arnd@xxxxxxxx>' line at
the start and the second Signed-off-by below mine.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/