Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

From: Christopher Hall
Date: Wed Oct 14 2015 - 22:47:39 EST


On Tue, 13 Oct 2015 06:59:26 -0700, Richard Cochran <richardcochran@xxxxxxxxx> wrote:

On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote:

+struct ptp_sys_offset_precise {
+ unsigned int rsv[4]; /* Reserved for future use. */
+ struct ptp_clock_time dev;
+ struct ptp_clock_time sys;
+};
+

Please put the reserved field at the bottom. Also, since we reading
the raw monotonic time under the hood, we might as well return it in

Good idea.

Thanks,
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/