Re: [PATCH 2/3] of: add URT UMSH-8596MD-xT panel DT bindings

From: Rob Herring
Date: Tue Oct 13 2015 - 09:30:42 EST


On Thu, Oct 8, 2015 at 3:27 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> On Wed, Oct 07, 2015 at 11:00:51PM +0200, Maciej S. Szmigiero wrote:
>> This patch adds DT bindings for United Radiant Technology
>> UMSH-8596MD-xT 7.0" WVGA TFT LCD panels.
>>
>> Signed-off-by: Maciej Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>>
>> diff --git a/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>> new file mode 100644
>> index 0000000..57c5fa4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>> @@ -0,0 +1,12 @@
>> +United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel
>> +
>> +Supported are LVDS versions (-11T, -19T) and parallel ones
>> +(-T, -1T, -7T, -20T).
>> +
>> +Required properties:
>> +- compatible: should be one of:
>> + "urt,umsh-8596md-t", "urt,umsh-8596md-1t", "urt,umsh-8596md-7t",
>> + "urt,umsh-8596md-11t", "urt,umsh-8596md-19t" or "urt,umsh-8596md-20t".
>
> I'd probably list each of these on a single line for slightly more
> clarity, but no need to respin because of that.
>
> Rob, I remember there was some discussion a while back on whether or not
> there should be a standard way of describing lists of compatible values,
> do you know if anything was ever concluded on that topic?

We're working to move the documentation to YAML and describe
constraints like this with logic expressions, but we haven't settled
on anything yet. This case will probably be just one string per line.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/