Re: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag

[Sudeep Holla]

On 12/10/15 21:28, Tony Lindgren wrote:
> * Tony Lindgren <tony@xxxxxxxxxxx> [151012 13:27]:
> > * Sudeep Holla <sudeep.holla@xxxxxxx> [150921 08:52]:
> > > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
> > > be left enabled so as to allow them to work as expected during the
> > > suspend-resume cycle, but doesn't guarantee that it will wake the system
> > > from a suspended state, enable_irq_wake is recommended to be used for
> > > the wakeup.
> > >
> > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
> > > enable_irq_wake instead.
> >
> > Applying into omap-for-v4.4/cleanup thanks.
>
> Actually I don't think this does the right thing. The interrupts
> in the $subject patch are in the always on powerdomain, and we really

Agreed

> want them to be excluded from the suspend.

OK but what's wrong with this patch. At-least the name suggest it's a
wakeup interrupt. And using IRQF_NO_SUSPEND for the wakeup interrupt is
simply wrong.

> So not applying without further explanations.

But I don't understand the real need for IRQF_NO_SUSPEND over wakeup APIs ?

--
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/