Re: [PATCH] zsmalloc: remove unless line in obj_free

[Hui Zhu]

Thanks.  I will post a new version later.

Best,
Hui

On Tue, Oct 13, 2015 at 4:00 PM, Sergey Senozhatsky
<sergey.senozhatsky.work@xxxxxxxxx> wrote:
> On (10/13/15 14:31), Hui Zhu wrote:
>> Signed-off-by: Hui Zhu <zhuhui@xxxxxxxxxx>
>
> s/unless/useless/
>
> other than that
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
>         -ss
>
>> ---
>>  mm/zsmalloc.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
>> index f135b1b..c7338f0 100644
>> --- a/mm/zsmalloc.c
>> +++ b/mm/zsmalloc.c
>> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>>       struct page *first_page, *f_page;
>>       unsigned long f_objidx, f_offset;
>>       void *vaddr;
>> -     int class_idx;
>> -     enum fullness_group fullness;
>>
>>       BUG_ON(!obj);
>>
>> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>>       obj_to_location(obj, &f_page, &f_objidx);
>>       first_page = get_first_page(f_page);
>>
>> -     get_zspage_mapping(first_page, &class_idx, &fullness);
>>       f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>>
>>       vaddr = kmap_atomic(f_page);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/