Re: [PATCH v2 1/3] mfd: sec-core: Dump PMIC revision to find out the HW

From: Lee Jones
Date: Tue Oct 13 2015 - 05:04:36 EST


On Wed, 07 Oct 2015, Krzysztof Kozlowski wrote:

> There are different revisions of the same chipset. For example S2MPS13 has
> more than 2 revisions. They differ slightly in regulator constraints.
> Print the revision number to easily find which PMIC is used on the board.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> ---
>
> Changs since v1:
> None.
> ---
> drivers/mfd/sec-core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 2d1137a7a0ee..589e5efc2d7f 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -253,6 +253,15 @@ static const struct regmap_config s5m8767_regmap_config = {
> .cache_type = REGCACHE_FLAT,
> };
>
> +static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic)
> +{
> + unsigned int val;
> +
> + /* For each device type, the REG_ID is always the first register */
> + if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val))
> + dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val);
> +}
> +
> #ifdef CONFIG_OF
> /*
> * Only the common platform data elements for s5m8767 are parsed here from the
> @@ -425,6 +434,7 @@ static int sec_pmic_probe(struct i2c_client *i2c,
> goto err_mfd;
>
> device_init_wakeup(sec_pmic->dev, sec_pmic->wakeup);
> + sec_pmic_dump_rev(sec_pmic);
>
> return ret;
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/