Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach

From: Kieran Bingham
Date: Mon Oct 12 2015 - 07:16:29 EST


Hi Wolfram,

On 12 October 2015 at 08:23, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> Hi Kiera,
>
> On Sun, Oct 11, 2015 at 12:39:31PM +0100, Kieran Bingham wrote:
>> A change of return status was introduced in commit 3fffd1283927
>> ("i2c: allow specifying separate wakeup interrupt in device tree")
>
> Thanks for catching this!

NP : Saw it when re-basing my other series.

>> The commit prevents the defer status being passed up the call stack
>> appropriately when dev_pm_domain_attach returns -EPROBE_DEFER.
>>
>> To fix we change this back to the original return status;
>
> What about going to the error path?

Sounds reasonable :D


>> Signed-off-by: Kieran Bingham <kieranbingham@xxxxxxxxx>
>
> Please add a "Fixes: <sha1>" tag here.

Sure.

>
> Wolfram
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/