Re: [PATCH net-next v3] BNX2: fix a Null Pointer for stats_blk

From: David Miller
Date: Sun Oct 11 2015 - 07:51:50 EST


From: Weidong Wang <wangweidong1@xxxxxxxxxx>
Date: Thu, 8 Oct 2015 18:03:47 +0800

> we have two processes to do:
> P1#: ifconfig eth0 down; which will call bnx2_close, then will
> , and set Null to stats_blk
> P2#: ifconfig eth0; which will call bnx2_get_stats64, it will
> use stats_blk.
> In one case:
> --P1#-- --P2#--
> stats_blk(no null)
> bnx2_free_mem
> ->bp->stats_blk = NULL
> GET_64BIT_NET_STATS
>
> then it will cause 'NULL Pointer' Problem.
> it is as well with 'ethtool -S ethx'.
>
> Allocate the statistics block at probe time so that this problem is
> impossible
>
> Signed-off-by: Wang Weidong <wangweidong1@xxxxxxxxxx>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/