Re: [GIT PULL] strscpy powerpc fix for 3.4

From: Guenter Roeck
Date: Thu Oct 08 2015 - 14:46:02 EST


On Wed, Oct 07, 2015 at 08:27:38PM -0400, Chris Metcalf wrote:
> On 10/7/2015 6:44 PM, Stephen Rothwell wrote:
> >Hi Linus,
> >
> >After merging Linus' tree, today's linux-next build (powerpc
> >ppc64_defconfig) failed like this:
> >
> >lib/string.c: In function 'strscpy':
> >lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
> > *(unsigned long *)(dest+res) = c & zero_bytemask(data);
> > ^
> >
> >Caused by commit
> >
> > 30035e45753b ("string: provide strscpy()")
>
> I posted a change equivalent to yours earlier today:
>
> http://lkml.kernel.org/r/1444229188-19640-1-git-send-email-cmetcalf@xxxxxxxxxx
>
> I also did no testing, but since the rest of the PPC code is similar to the
> asm-generic version, I believe the zero_bytemask() definition should be OK.
>
> It probably should go through Linus' tree, like the previous set of patches.
> I just pushed it up to the linux-tile tree for Linus to grab as:
>
Wonder if Linus is going to realize that you meant 4.3 in your subject line,
not 3.4.

Guenter

> git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git strscpy
>
> Chris Metcalf (1):
> arch/powerpc: provide zero_bytemask() for big-endian
>
> arch/powerpc/include/asm/word-at-a-time.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --
> Chris Metcalf, EZChip Semiconductor
> http://www.ezchip.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/