Re: [PATCH] serial: atmel: fix compiler warning on address cast

From: Russell King - ARM Linux
Date: Thu Oct 08 2015 - 05:38:10 EST


On Thu, Oct 08, 2015 at 11:01:48AM +0200, Alexandre Belloni wrote:
> On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
> > Turning on KVM and LPAE support on top of a multi_v7_defconfig will
> > produce a compiler warning in the Atmel serial driver:
> > drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
> > drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > if ((void *)port->mapbase != ser->iomem_base)
> > ^
> >
> > Fix that by using the cast on the right hand side instead, as similar
> > code already does in other drivers.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>

Hmm, this actually points at a problem, and the cast screems out about it.
Think about it, can you guess what it is?

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/