Re: [PATCH] PM / OPP: fix debugfs files for 64-bit

From: Greg Kroah-Hartman
Date: Wed Oct 07 2015 - 08:57:50 EST


On Wed, Oct 07, 2015 at 04:51:49PM +0530, Viresh Kumar wrote:
> On 07-10-15, 12:07, Greg Kroah-Hartman wrote:
> > Why would you be wanting to create a "unsigned long" as an api anyway?
> > Just force it to be u64 all the time, can't you do that?
>
> Okay, so the variable in question (lets say frequency) is an 'unsigned
> long' and that's how all the APIs of clock framework expect/define
> it.
>
> And you are probably saying that we do this:
>
> unsigned long freq;
>
> debugfs_create_u64((u64 *)&freq);
>
> Right? Or are you asking to update clock APIs to be converted to u64?

Yes, they should be u64 as I doubt you want to debug problems that you
have in the driver where it works on a 64bit system but doesn't on a
32bit one.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/