Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume

From: Mark Brown
Date: Tue Oct 06 2015 - 07:00:21 EST


On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote:

> + /* All registers have been reset to default value without calling
> + * to regmap interface, even if reset fails, some registers
> + * maybe in intermediate status, so we need to mark regmap
> + * cache_dirty flag.
> + */
> + regcache_mark_dirty(wm8962->regmap);

This is a standard thing that applies to almost all devices, there
should be no need for such an extensive comment (which would normally
flag up that there's something weird and surprising going on).

Attachment: signature.asc
Description: Digital signature