Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure

From: Ingo Molnar
Date: Tue Oct 06 2015 - 04:23:18 EST



* Andy Lutomirski <luto@xxxxxxxxxx> wrote:

> Commit 131484c8da97 ("x86/debug: Remove perpetually broken,
> unmaintainable dwarf annotations") removed all the manual DWARF
> annotations outside the vDSO. It also removed the macros we used
> for the manual annotations.
>
> Re-add the macros so that we can clean up the vDSO annotations.
>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> ---
> arch/x86/Makefile | 10 ++-
> arch/x86/include/asm/dwarf2.h | 170 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 178 insertions(+), 2 deletions(-)
> create mode 100644 arch/x86/include/asm/dwarf2.h

Please don't add all this gunk back in!

AFAICS the later patches use just a very small subset - add only the minimal
subset absolutely needed.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/