Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x

From: Francois Romieu
Date: Tue Oct 06 2015 - 03:35:30 EST


Andrej Ota <andrej@xxxxxx> :
> Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in
> vlan receive code.") which broke VLAN tag parsing on receive.
>
> Because eth_type_trans() consumes ethernet header worth of bytes, a call
> to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's
> reading from an invalid offset.
>
> Tested to be working on PCEngines Alix board.
>
> Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.")
> Signed-off-by: Andrej Ota <andrej@xxxxxx>

Minor nits:
- Ethernet driver patches should usually be sent to netdev@xxxxxxxxxxxxxxxx
Their state is thus tracked at
http://patchwork.ozlabs.org/project/netdev/list/

- The more specific about the target branch, the better:
[PATCH net 1/1] via-rhine: blah
-> patch against davem's bugfixes branch
[PATCH net-next 19/73] foo: more balh
-> patch against davem's dev branch

- davem will take care of -stable propagation

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/