Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure
From: David B. Robins
Date: Mon Oct 05 2015 - 09:27:58 EST
On 2015-10-05 06:31, David Miller wrote:
From: "David B. Robins" <linux@xxxxxxxxxxxxxxx>
Date: Wed, 30 Sep 2015 16:20:04 -0400
If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will
return
but not clear rx->size. rx points to driver private data. A later call
assumes that nonzero size means ax_skb was allocated and passes a null
ax_skb to skb_put. Changed allocation failure return to clear size
first.
Found testing board with AX88772B devices.
Signed-off-by: David B. Robins <linux@xxxxxxxxxxxxxxx>
Applied, thanks.
While I am happy for the patch I submitted to be applied, and it is
consistent with existing error handling and does fix the specific issue,
I believe a later series of 5 patches by Dean Jenkins that more
comprehensively address the issue (grouped under subject "Improve ASIX
RX memory allocation error handling") should be preferred.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/