Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver

From: David Miller
Date: Mon Oct 05 2015 - 06:45:10 EST


From: David Miller <davem@xxxxxxxxxxxxx>
Date: Mon, 05 Oct 2015 03:54:55 -0700 (PDT)

> From: jon@xxxxxxxxxx
> Date: Thu, 1 Oct 2015 07:43:21 -0400
>
>> From: Jon Ringle <jringle@xxxxxxxxxxxxx>
>>
>> This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet
>> controller over a SPI bus interface. This driver makes use of the regmap API to
>> optimize access to registers by caching registers where possible.
>>
>> Datasheet:
>> http://ww1.microchip.com/downloads/en/DeviceDoc/39935b.pdf
>>
>> Signed-off-by: Jon Ringle <jringle@xxxxxxxxxxxxx>
>
> Applied.

Actually, I had to revert both patches. Please look at the compiler
warnings your code generates:

drivers/mfd/wm5110-tables.c: In function ʽwm5110_patchʼ:
drivers/mfd/wm5110-tables.c:281:11: warning: passing argument 2 of ʽregmap_register_patchʼ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm5110-tables.c:15:
include/linux/regmap.h:727:5: note: expected ʽconst struct reg_sequence *ʼ but argument is of type ʽconst struct reg_default *ʼ
drivers/mfd/wm8998-tables.c: In function ʽwm8998_patchʼ:
drivers/mfd/wm8998-tables.c:50:10: warning: passing argument 2 of ʽregmap_register_patchʼ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm8998-tables.c:15:
include/linux/regmap.h:727:5: note: expected ʽconst struct reg_sequence *ʼ but argument is of type ʽconst struct reg_default *ʼ
N?§²ζμrΈ?yϊθ?Ψb²X¬ΆΗ§vΨ^?)ήΊ{.nΗ+?·??{±?κηzX§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨Ύ«?κηzZ+?Κ+zf£ʼ·h??§~?­?Ϋi?ϋΰzΉ?w?ʼΈ??¨θ­Ϊ&ʼ)ίʼf?ω^jΗ«y§m?α@A«aΆΪ? 0Άμh?ε?i