Re: [PATCH 4/4] nvmem: sunxi: Check for memory allocation failure

From: Srinivas Kandagatla
Date: Sun Oct 04 2015 - 10:41:04 EST




On 04/10/15 12:04, Greg KH wrote:
On Wed, Sep 30, 2015 at 01:36:31PM +0100, Srinivas Kandagatla wrote:
From: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

The sunxi_sid driver doesn't check for kmalloc return status before
derefencing the returned pointer, which could lead to a NULL pointer
dereference if kmalloc failed. Check for its return code to make sure it
deosn't happen.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
---
drivers/nvmem/sunxi_sid.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

No signed-off-by: from you on this patch?


Oops!! My bad I missed the sign-off.

Thanks for taking this patch, I will make sure I will recheck this before sending.

--srini

:(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/