Re: [PATCH 16/18] Input: elan_i2c - simplify function return logic

From: Benson Leung
Date: Fri Oct 02 2015 - 12:46:27 EST


On Fri, Oct 2, 2015 at 6:40 AM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> This also fixes the following make coccicheck warning:
>
> drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be simplified
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>


--
Benson Leung
Software Engineer, Chrom* OS
bleung@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/