Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found

From: Neil Armstrong
Date: Fri Oct 02 2015 - 08:11:08 EST


On 10/01/2015 06:32 PM, Andrew Lunn wrote:
> On Thu, Oct 01, 2015 at 05:27:32PM +0200, Neil Armstrong wrote:
>> On 09/30/2015 10:21 AM, Neil Armstrong wrote:
>>> If no switch were found in dsa_setup_dst, return -ENODEV and
>>> exit the dsa_probe cleanly.
>
> ...
>
>> Couldn't we use the probe defer mechanism here ? (until complete rework is done)
>
> Hi Neil
>
> I was thinking the same last night. We know the switch should be
> there, otherwise it would not be in DT. So returning -EPROBE_DEFER
> would be valid.
>
> Andrew
>
Hi,

It makes sens but does a module insertion triggers the differed probe ?

I will still post this change in a next set of patch.

Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/