Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32

From: Brian Gerst
Date: Thu Oct 01 2015 - 09:02:50 EST


On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
>
>> diff --git a/arch/x86/include/uapi/asm/bitsperlong.h b/arch/x86/include/uapi/asm/bitsperlong.h
>> index b0ae1c4..217909b 100644
>> --- a/arch/x86/include/uapi/asm/bitsperlong.h
>> +++ b/arch/x86/include/uapi/asm/bitsperlong.h
>> @@ -1,7 +1,7 @@
>> #ifndef __ASM_X86_BITSPERLONG_H
>> #define __ASM_X86_BITSPERLONG_H
>>
>> -#ifdef __x86_64__
>> +#if defined(__x86_64__) && !defined(__ILP32__)
>> # define __BITS_PER_LONG 64
>
> Can we write this as:
>
> #ifdef __ILP64__

Do all versions of gcc/clang define that, even if x32 isn't supported?

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/