Re: [PATCH 3/6 RESEND] mfd: arizona: Downgrade type mismatch messages to dev_warn

From: Lee Jones
Date: Thu Oct 01 2015 - 07:17:25 EST


On Mon, 28 Sep 2015, Richard Fitzgerald wrote:

> If the declared codec type doesn't match the detected type
> we issue a log message but carry on registering the device,
> so a dev_warn() is appropriate rather than a dev_err()
>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/mfd/arizona-core.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

For my own reference:
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 73d26dd..cb09172 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1132,8 +1132,8 @@ int arizona_dev_init(struct arizona *arizona)
> case 0x5102:
> type_name = "WM5102";
> if (arizona->type != WM5102) {
> - dev_err(arizona->dev, "WM5102 registered as %d\n",
> - arizona->type);
> + dev_warn(arizona->dev, "WM5102 registered as %d\n",
> + arizona->type);
> arizona->type = WM5102;
> }
> apply_patch = wm5102_patch;
> @@ -1151,8 +1151,8 @@ int arizona_dev_init(struct arizona *arizona)
> break;
> default:
> type_name = "WM5110";
> - dev_err(arizona->dev, "WM5110 registered as %d\n",
> - arizona->type);
> + dev_warn(arizona->dev, "WM5110 registered as %d\n",
> + arizona->type);
> arizona->type = WM5110;
> break;
> }
> @@ -1163,8 +1163,8 @@ int arizona_dev_init(struct arizona *arizona)
> case 0x8997:
> type_name = "WM8997";
> if (arizona->type != WM8997) {
> - dev_err(arizona->dev, "WM8997 registered as %d\n",
> - arizona->type);
> + dev_warn(arizona->dev, "WM8997 registered as %d\n",
> + arizona->type);
> arizona->type = WM8997;
> }
> apply_patch = wm8997_patch;
> @@ -1183,8 +1183,8 @@ int arizona_dev_init(struct arizona *arizona)
>
> default:
> type_name = "WM8998";
> - dev_err(arizona->dev, "WM8998 registered as %d\n",
> - arizona->type);
> + dev_warn(arizona->dev, "WM8998 registered as %d\n",
> + arizona->type);
> arizona->type = WM8998;
> }
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/