Re: [PATCH -mm v2 2/3] mm/oom_kill: cleanup the "kill sharing same memory" loop

From: David Rientjes
Date: Wed Sep 30 2015 - 17:15:21 EST

Next message: Andrew Morton: "Re: [PATCH] mm: swap: Use swap_lock to prevent parallel swapon activations instead of i_mutex"
Previous message: David Rientjes: "Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process()"
In reply to: Oleg Nesterov: "[PATCH -mm v2 2/3] mm/oom_kill: cleanup the "kill sharing same memory" loop"
Next in thread: Oleg Nesterov: "[PATCH -mm v2 3/3] mm/oom_kill: fix the wrong task->mm == mm checks in oom_kill_process()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 30 Sep 2015, Oleg Nesterov wrote:

> Purely cosmetic, but the complex "if" condition looks annoying to me.
> Especially because it is not consistent with OOM_SCORE_ADJ_MIN check
> which adds another if/continue.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: [PATCH] mm: swap: Use swap_lock to prevent parallel swapon activations instead of i_mutex"
Previous message: David Rientjes: "Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process()"
In reply to: Oleg Nesterov: "[PATCH -mm v2 2/3] mm/oom_kill: cleanup the "kill sharing same memory" loop"
Next in thread: Oleg Nesterov: "[PATCH -mm v2 3/3] mm/oom_kill: fix the wrong task->mm == mm checks in oom_kill_process()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]