Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

From: Arnaldo Carvalho de Melo
Date: Wed Sep 30 2015 - 15:45:46 EST


Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu:
> On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote:
> > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001
> > From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> > Date: Thu, 24 Sep 2015 17:53:49 -0400
> > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
> >
> > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false.
> > So the weak definition for 'sample_regs_masks' doesn't get picked up.
> >
> > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition
> > error for 'perf_reg_value()' function (due to the static inline version
> > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> > function.
> >
> > Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Thanks, applied.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/