Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver

From: Matthew Garrett
Date: Wed Sep 30 2015 - 02:03:02 EST


On Wed, Sep 30, 2015 at 08:58:35AM +0300, Jarkko Sakkinen wrote:
> Right. I think it would make sense to be conservative and use
> acpi_driver only for MSFT0101 because at least I don't know answer
> to this question. It would be a risk to take these fixes to the stable
> kernels othwerwise.

In that case I'd suggest just adding it to the platform driver struct
and tidying up the init path a little (and having the platform driver
init code request resources rather than hardcoding them). It'll make it
easier to deal with any systems that declare TPMs in other tables such
as Device Tree later on.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/