Re: [RFC][PATCH 01/11] sched: Simplify INIT_PREEMPT_COUNT

From: Peter Zijlstra
Date: Tue Sep 29 2015 - 10:53:30 EST


On Tue, Sep 29, 2015 at 10:43:32AM -0400, Steven Rostedt wrote:
>
> [ Resend with a "Reply-all" this time! ]
>
> On Tue, 29 Sep 2015 11:28:26 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > As per commit d86ee4809d03 ("sched: optimize cond_resched()") we need
> > PREEMPT_ACTIVE to avoid cond_resched() from working before the
> > scheduler is setup.
> >
> > However, keeping preemption disabled should do the same thing already,
> > making the PREEMPT_ACTIVE part entirely redundant.
>
> Thus PREEMPT_ACTIVE wasn't needed at that commit either, or was it?

Correct. We might have actually discussed that at that time but decided
to be conservative -- but these be vague memories..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/