Re: [RFC][PATCH 02/11] sched: Create preempt_count invariant

[Steven Rostedt]

On Tue, 29 Sep 2015 15:02:01 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, Sep 29, 2015 at 02:55:13PM +0200, Frederic Weisbecker wrote:
> > On Tue, Sep 29, 2015 at 11:28:27AM +0200, Peter Zijlstra wrote:
> > >  #define init_task_preempt_count(p) do { \
> > > -	task_thread_info(p)->preempt_count = PREEMPT_DISABLED; \
> > > +	task_thread_info(p)->preempt_count = 2*PREEMPT_DISABLED; \
> > 
> > Since it's not quite obvious why we use this magic value without looking
> > at schedule_tail() details, maybe add a little comment? (Just "/* see schedule_tail() */").
> 
> Right, I fixed that in 12/11 v2. I'll change that around a bit.

I'll wait for v2 because this confused me too.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/