Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value

From: Vladimir Murzin
Date: Tue Sep 29 2015 - 08:18:07 EST


On 16/09/15 15:21, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@xxxxxxx>
>
> Use the system wide value of ID_AA64DFR0 to make safer decisions
>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@xxxxxxx>
> ---
> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------
> arch/arm64/kernel/debug-monitors.c | 6 ++++--
> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++-
> 3 files changed, 24 insertions(+), 15 deletions(-)
>

Looks like this patch introduces build-time regression if
CONFIG_PERF_EVENTS is not set:

> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension':
> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps'
> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps'
> make: *** [vmlinux] Error 1

Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/