RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

[Chen, Yu C]

Hi,

> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx]
> Sent: Monday, September 28, 2015 8:56 PM
> To: Chen, Yu C
> Cc: Wysocki, Rafael J; jiang.liu@xxxxxxxxxxxxxxx; Zhang, Rui; Brown, Len; linux-
> kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
> suspend-to-idle
> 
> On Monday, September 28, 2015 01:51:09 AM Chen, Yu C wrote:
> > Hi, Rafael,
> >
> > > -----Original Message-----
> > > From: linux-pm-owner@xxxxxxxxxxxxxxx [mailto:linux-pm-
> > > owner@xxxxxxxxxxxxxxx] On Behalf Of Rafael J. Wysocki
> > > Sent: Sunday, September 27, 2015 9:30 PM
> > > To: Chen, Yu C
> > > Cc: Wysocki, Rafael J; jiang.liu@xxxxxxxxxxxxxxx; Zhang, Rui; Brown,
> > > Len; linux- kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > setting before suspend-to-idle
> > >
> > > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote:
> > > > Hi, Rafael,
> > > >
> > > > > -----Original Message-----
> > > > > From: linux-pm-owner@xxxxxxxxxxxxxxx [mailto:linux-pm-
> > > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Rafael J. Wysocki
> > > > > Sent: Friday, September 25, 2015 9:57 PM
> > > > > To: Chen, Yu C
> > > > > Cc: Wysocki, Rafael J; jiang.liu@xxxxxxxxxxxxxxx; Zhang, Rui;
> > > > > Brown, Len; linux- kernel@xxxxxxxxxxxxxxx;
> > > > > linux-pm@xxxxxxxxxxxxxxx
> > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > > setting before suspend-to-idle
> > > > >
> > > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
> > > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version.
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx]
> > > > > > > Sent: Friday, September 25, 2015 9:24 AM
> > > > > > > To: Chen, Yu C
> > > > > > > Cc: Wysocki, Rafael J; jiang.liu@xxxxxxxxxxxxxxx; Zhang,
> > > > > > > Rui; Brown, Len; linux- kernel@xxxxxxxxxxxxxxx;
> > > > > > > linux-pm@xxxxxxxxxxxxxxx
> > > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup
> > > > > > > irq setting before suspend-to-idle
> > > > > > >
> > > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> > > > >
> > Because the name of acpi_irq is already used by acpi irq handler at
> > drivers/acpi/osl.c:
> > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
> 
> Ah, this is the name of the handler.  I forgot about that, sorry.
> 
> Well, it might be worth renaming the handler to something like
> acpi_interrupt(), then.
OK, will rewrite the patch, Thanks!

Best Regards,
Yu